New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine log console message UX #7448
Conversation
… log entries. This makes it clearer when new things are coming in, and gives a sense for how many new things.
…ould be combined. This allows subclasses of output area to define their own collapsing semantics, which may be less aggressive than the default output area behavior.
…ch is the resolution for our timestamp). This means that visually, we are telling the truth with the timestamp - every message displayed with that time is the same time, to the resolution of the display (which is one second).
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
@ivanov - does this address most of your concerns? @mbektasbbg - does this also address some of the thoughts you had regarding how log messages are treated and displayed? |
thanks @jasongrout this looks great to me. I can still reproduce #7443 with these changes though. |
@jasongrout I tested again and I am no longer able to reproduce #7443 . Looks good to me. |
Thanks! |
@meeseeksdev backport to 1.x |
…8-on-1.x Backport PR #7448 on branch 1.x (Refine log console message UX)
References
Fixes #7444 and appears to also fix #7443
Code changes
User-facing changes
Backwards-incompatible changes
I don't think there are any backwards incompatible changes. The one function signature that changes is a private function to the module.